Yes, the DE-specific implementations is pointless (as far as I know, I use a WM), but the XDG implementation is actually used first, and the function returns true if any impl returns true, like xdg() || gnome() || gnome_old() || kde().

True, I must’ve read the code wrong when making the comment.

This isn’t that bad?

Yes, which is why I take issue with a PR (or rather what should have been a PR) that introduces crap code with clearly visible low effort improvements - the submitter should’ve already done that so the project doesn’t unnecessarily gain technical debt by accepting the change.

With multiple impls, you have to resolve conflicts somehow.

Yep, that’s why I think it’s important for the implementations to actually differentiate between light and fail state - that’s the smallest change and allows you to keep the whole detection logic in the individual implementations. Combine that with XDG being the default/first one and you get something reasonable (in a world where the separate implementations are necessary). You do mention this, but I feel like the whole two paragraphs are just expanding on this idea.

But it’s better to criticize the code’s actual faults (…)

I made a mistake with the order in which the implementations are called, but I consider the rest of the comment to still stand and the criticisms to be valid.

Aren’t most newer games just using in-engine cutscenes nowadays?

Well, the detection is broken for KDE and backwards in the XDG implementation (which is also only used as a fallback when the three DE-specific implementations fail, even though all of them actually support XDG so having separate implementations is pointless).

Also with the way it’s implemented, it will have unexpected results for users who have both KDE and Gnome installed (or at least have leftover configuration files) - if you for example used KDE in the past with a theme considered to be “dark” by this and now use Gnome and have it set to light mode, you will get dark mode GZdoom with no obvious reason why.

Oh and the XDG implementation is also very fragile and will not work on everyone’s system because it depends on a specific terminal utility being installed. The proper way would be to use a DBus library and get the settings through that.

And when somebody comes to fix it, they will have to figure out a) what’s so special about the DE-specific implementations that XDG wasn’t enough (they might just assume that XDG isn’t supported widely enough), b) learn how to detect dark theme properly on the DE they’re fixing, c) rework the code so that there is a difference between “this DE wants light mode” and “couldn’t figure out of this DE is in light or dark mode” - both of these are now represented by the “false” return value.

I don’t think a well written and functioning code made with AI assistance would get a response this strong, but the problem here is that the code is objectively bad and its (co-)author kept doubling down about something they probably barely even checked.

Don’t know about the UK, but in central Europe it’s common for houses to get three phase power that can then be used on 400V three phase circuits and gets split (ideally evenly) into 240V circuits. And the fact that the phases have effectively zero coupling means that you also need to just try the adapter to find out if it’s going to work or not unless you happen to know how exactly your house is wired up, just like with split phase power.

Apartments usually get a single phase though, but IMHO it’s also less likely that WiFi won’t be enough there, so it’s questionable if that’s even a point for powerline.

You don’t need any swap space for suspend to work

It is, but it still works

The download will simply fail if the version pacman wants to download isn’t available on the mirror. The version is part of the download URL.

OK, what exactly does an average person need a computer for that cannot be adequately done on a phone? Because I do have a few relatives with computers that just gather dust permanently returned off, and they don’t seem to mind.

“Oh, you didn’t spend at least a few hundred dollars on a device that you aren’t going to use for anything except flashing a custom ROM once? What a moron!”

Right, but the commenter above me seems to suggest that GrapheneOS removed the battery management in order to bring the charging limit back, which is why I asked.

Wait, did Android 16 QPR 1 remove the charging limit for newer Pixels? My 7a has both the Battery health assistance option and the original optimization modes (off, adaptive charging and 80%).

Wayland does force clients to be able to cope with a compositor that doesn’t do SSD - CSD support is mandatory, SSD optional.

That’s a weird question to ask under a post about an Android update. To answer anyway, the answer is probably yes - there is a GSI variant of Ubuntu Touch now, and there are projects that make your phone always boot into a GSI. If you combine these two things, you should get a Pixel that always boots into Ubuntu Touch.

Not with CGNAT

It’s a crappy clickbait title, I don’t see why it shouldn’t get downvoted

I guess how much people care also depends on whether they tend to use laptops in ways and places that are prone to causing damage to the ports. I’ve never damaged any port on any laptop I’ve ever owned, and it’s unlikely I ever will because I like to keep the cables organized and out of the way (so it would require conscious effort to tug on them), and when I want to pick my laptop up, I always quickly run my hand around its perimeter to make sure everything is disconnected.

I do not claim that this is the correct way to use a laptop or that others should do the same, it is a tool that should be used the way its user needs, I just want to point out that for some usecases, this is simply a non-issue in the same way a non-replaceable CPU is - nothing’s going to happen to it.

Also, my current laptop does have both a barrel jack (probably works, I’ve never used it) and a USB-C charging connector, so it’s not necessarily an either-or proposition.

Also, Google is no longer releasing the Pixel-specific source code, meaning you can no longer just build AOSP for new Pixels and have all the hardware just work - this makes it harder for custom ROM developers and might eventually lead to some hardware being simply unsupported unless you use the stock ROM.

deleted by creator

Your screenshot is misleading - apps installed from alternative marketplaces on iOS also need to be signed by a certificate linked to a known developer by Apple, exactly like Google wants to do it on Android.

Maybe you’ve tried that already, but does the tablet show up as a USB device when you connect it to a computer? Android devices tend to enter fastboot or another firmware upload mode when everything else fails.